neocgit

a more 'modern' version of cgit
Log | Files | Refs | Submodules | README | LICENSE | git clone https://git.ne02ptzero.me/git/neocgit

commit 66091f934a2d064ae55095cdc5ae008b43ea60fe
parent 5cd2bf7e7f3f3daf6107cd3a269bad78e342de70
Author: Lars Hjemli <hjemli@gmail.com>
Date:   Tue, 16 Jan 2007 18:41:01 +0100

Handle empty/malformed commit messages

An empty commit message would trigger a segfault in the current
cgit_parse_commit().

Also, make sure that all char-pointers are properly initialized.

Diffstat:
Mparsing.c | 19+++++++++++++------
1 file changed, 13 insertions(+), 6 deletions(-)

diff --git a/parsing.c b/parsing.c @@ -145,6 +145,12 @@ struct commitinfo *cgit_parse_commit(struct commit *commit) ret = xmalloc(sizeof(*ret)); ret->commit = commit; + ret->author = NULL; + ret->author_email = NULL; + ret->committer = NULL; + ret->committer_email = NULL; + ret->subject = NULL; + ret->msg = NULL; if (strncmp(p, "tree ", 5)) die("Bad commit: %s", sha1_to_hex(commit->object.sha1)); @@ -180,12 +186,13 @@ struct commitinfo *cgit_parse_commit(struct commit *commit) p = strchr(p, '\n') + 1; t = strchr(p, '\n'); - ret->subject = substr(p, t); - p = t + 1; - - while (*p == '\n') - p = strchr(p, '\n') + 1; - ret->msg = p; + if (t && *t) { + ret->subject = substr(p, t); + p = t + 1; + while (*p == '\n') + p = strchr(p, '\n') + 1; + ret->msg = p; + } return ret; }