Author: John Keeping <email@example.com>
Date: Sat, 18 May 2013 15:17:08 +0100
Makefile: fix parallel "make test"
When building the "test" target we depend on both cgit and building the
Git tools. By doing this with two targets we end up running make in the
git/ directory twice, concurrently if using parallel make, which causes
us to build more than we need and potentially builds incorrectly if
multi-step build-then-move operations overlap.
Fix this by instead calling back into the makefile so that we alter the
"cgit" target to also build the Git tools.
Signed-off-by: John Keeping <firstname.lastname@example.org>
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/Makefile b/Makefile
@@ -64,12 +64,10 @@ endif
- $(QUIET_SUBDIR0)git $(QUIET_SUBDIR1) -f ../cgit.mk ../cgit NO_CURL=1
+ $(QUIET_SUBDIR0)git $(QUIET_SUBDIR1) -f ../cgit.mk ../cgit $(EXTRA_GIT_TARGETS) NO_CURL=1
- $(QUIET_SUBDIR0)git $(QUIET_SUBDIR1) NO_CURL=1
-test: all git
+ @$(MAKE) --no-print-directory cgit EXTRA_GIT_TARGETS=all
$(QUIET_SUBDIR0)tests $(QUIET_SUBDIR1) all